Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check if MaxReplicaCount is nil before access to it #4565

Closed
wants to merge 1 commit into from
Closed

fix: Check if MaxReplicaCount is nil before access to it #4565

wants to merge 1 commit into from

Conversation

JorTurFer
Copy link
Member

In ScaledJobs, during the min/max replica calculation, we access to MaxReplicaCount withoutnchecking if it's nil and it produces panic in case of nil

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

@JorTurFer
fix: Check if MaxReplicaCount is nil before access to it
2d51e79 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer requested a review from a team as a code owner May 22, 2023 19:16
@zroubalik
Copy link
Member

zroubalik commented May 23, 2023 •
edited by github-actions bot
Loading

/run-e2e min_replica_sj
Update: You can check the progress here

@zroubalik zroubalik mentioned this pull request May 23, 2023
Merged
2 tasks
@zroubalik
Copy link
Member

@JorTurFer is there an issue for this?

@zroubalik
Copy link
Member

closing in favor of #4567

@zroubalik zroubalik closed this May 23, 2023
@JorTurFer JorTurFer deleted the fix-panic branch July 27, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugen-nw eugen-nw eugen-nw approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @zroubalik @eugen-nw